danielepintore/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-01 03:55:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(cmd): adapt TestCliCmdError to urfave/cli v3.10 behavior

Browse Source 
cli v3.10.0 now prints the usage help to stdout (in addition to the
"Incorrect Usage" message on stderr) when a command gets an unknown
flag, so the test can no longer assert an empty stdout.

Assisted-by: Claude:Opus-4.8
This commit is contained in:
silverwind
2026-06-27 13:38:14 +02:00
parent 8d9b991407
commit 1c4989c193
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/cmdtest/cmd_test.go
View File

@@ -202,7 +202,7 @@ func TestCliCmdError(t *testing.T) {
r, err = runTestApp(app, "./gitea", "test-cmd", "--no-such")
assert.Error(t, err)
assert.Equal(t, 1, r.ExitCode)
assert.Empty(t, r.Stdout)
assert.NotEmpty(t, r.Stdout) // since cli v3.10, the usage help is printed to stdout on a usage error
assert.Equal(t, "Incorrect Usage: flag provided but not defined: -no-such\n\n", r.Stderr)
app = newTestApp(cli.Command{Action: func(ctx context.Context, cmd *cli.Command) error { return nil }})