refactor(preview-deployment): remove dynamic import of getWebServerSettings and streamline IP retrieval logic

This commit is contained in:
Mauricio Siu
2025-12-21 01:43:09 -06:00
parent 6010643d9e
commit f1dfa9c6a2
2 changed files with 5 additions and 8 deletions

View File

@@ -9,7 +9,10 @@ import { IS_CLOUD } from "../constants";
import { db } from "../db";
import * as schema from "../db/schema";
import { getUserByToken } from "../services/admin";
import { getWebServerSettings } from "../services/web-server-settings";
import {
getWebServerSettings,
updateWebServerSettings,
} from "../services/web-server-settings";
import { getHubSpotUTK, submitToHubSpot } from "../utils/tracking/hubspot";
import { sendEmail } from "../verification/send-verification-email";
import { getPublicIpWithFallback } from "../wss/utils";
@@ -124,9 +127,6 @@ const { handler, api } = betterAuth({
});
if (!IS_CLOUD) {
const { updateWebServerSettings } = await import(
"../services/web-server-settings"
);
await updateWebServerSettings({
serverIp: await getPublicIpWithFallback(),
});

View File

@@ -13,11 +13,11 @@ import { removeDirectoryCode } from "../utils/filesystem/directory";
import { authGithub } from "../utils/providers/github";
import { removeTraefikConfig } from "../utils/traefik/application";
import { manageDomain } from "../utils/traefik/domain";
import { findUserById } from "./admin";
import { findApplicationById } from "./application";
import { removeDeploymentsByPreviewDeploymentId } from "./deployment";
import { createDomain } from "./domain";
import { type Github, getIssueComment } from "./github";
import { getWebServerSettings } from "./web-server-settings";
export type PreviewDeployment = typeof previewDeployments.$inferSelect;
@@ -253,9 +253,6 @@ const generateWildcardDomain = async (
}
if (!ip) {
const { getWebServerSettings } = await import(
"../services/web-server-settings"
);
const settings = await getWebServerSettings();
ip = settings?.serverIp || "";
}