Dokploy/dokploy
1
0
Fork 0
mirror of https://github.com/Dokploy/dokploy.git synced 2026-06-20 14:45:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: streamline volume backup command generation

Browse Source 
- Consolidated Docker command construction for volume backups into a base command to reduce redundancy.
- Enhanced service type handling for application and compose, ensuring proper scaling and stopping of services during backup.
- Improved readability and maintainability of the backup command logic by using template literals and consistent formatting.
This commit is contained in:
Mauricio Siu
2025-06-30 01:33:12 -06:00
parent c042c8c0c5
commit 9974b2326f
1 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
packages/server/src/utils/volume-backups/utils.ts
View File

@@ -1,6 +1,5 @@
import type { findVolumeBackupById } from "@dokploy/server/services/volume-backups";
import { getComposeContainer } from "../docker/utils";
import { findComposeById, paths, paths } from "../..";
import { findComposeById } from "../..";
export const createVolumeBackup = async (
volumeBackup: Awaited<ReturnType<typeof findVolumeBackupById>>,
@@ -18,45 +17,49 @@ const backupVolume = async (
) => {
const { serviceType, volumeName, turnOff } = volumeBackup;
if (turnOff) {
return `docker run --rm \
const baseCommand = `
docker run --rm \
-v ${volumeName}:/volume_data \
-v $(pwd):/backup \
ubuntu \
bash -c "cd /volume_data && tar cvf /backup/${volumeName}.tar ."`;
bash -c "cd /volume_data && tar cvf /backup/${volumeName}.tar ."
`;
if (turnOff) {
return baseCommand;
}
if (serviceType === "application") {
return `
docker service scale ${volumeBackup.application?.appName}=0
docker run --rm \
-v ${volumeName}:/volume_data \
-v $(pwd):/backup \
ubuntu \
bash -c "cd /volume_data && tar cvf /backup/${volumeName}.tar .
docker service scale ${volumeBackup.application?.appName}=1
"`;
${baseCommand}
docker service scale ${volumeBackup.application?.appName}=1
`;
}
if (serviceType === "compose") {
const compose = await findComposeById(
volumeBackup.compose?.composeId || "",
);
const { COMPOSE_PATH } = paths(!!compose.serverId);
let stopCommand = "";
let startCommand = "";
if (compose.composeType === "stack") {
stopCommand = `docker service scale ${compose.appName}_${volumeBackup.serviceName}=0`;
stopCommand = `
ACTUAL_REPLICAS=$(docker service inspect ${compose.appName}_${volumeBackup.serviceName} --format "{{.Spec.Mode.Replicated.Replicas}}")
docker service scale ${compose.appName}_${volumeBackup.serviceName}=0`;
startCommand = `docker service scale ${compose.appName}_${volumeBackup.serviceName}=$ACTUAL_REPLICAS`;
} else {
stopCommand = `docker compose down --remove-orphans`;
stopCommand = `
ID=$(docker ps -q --filter "label=com.docker.compose.project=${compose.appName}" --filter "label=com.docker.compose.service=${volumeBackup.serviceName}")
docker stop $ID`;
startCommand = `
ID=$(docker ps -q --filter "label=com.docker.compose.project=${compose.appName}" --filter "label=com.docker.compose.service=${volumeBackup.serviceName}")
docker start $ID`;
}
return `
docker run --rm \
-v ${volumeName}:/volume_data \
-v $(pwd):/backup \
ubuntu \
bash -c "cd /volume_data && tar cvf /backup/${volumeName}.tar ."`;
${stopCommand}
${baseCommand}
${startCommand}
`;
}
return ``;
};