Dokploy/dokploy
1
0
Fork 0
mirror of https://github.com/Dokploy/dokploy.git synced 2026-06-20 06:35:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: use shellsafe docker command

Browse Source 
- add `shEscape` function - add `safeDockerLoginCommand` - use the new
functions to contruct better registry login command
This commit is contained in:
Leonhard Breuer
2025-09-03 19:52:01 +02:00
parent aa7e382818
commit 4ca05414af
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/server/src/services/registry.ts
View File

@@ -10,6 +10,18 @@ import { IS_CLOUD } from "../constants";
export type Registry = typeof registry.$inferSelect;
function shQ(s: string): string {
if (!s) return "''";
return `'${s.replace(/'/g, `'\\''`)}'`;
}
function safeDockerLoginCommand(registry: string, user: string, pass: string) {
const escapedRegistry = shQ(registry)
const escapedUser = shQ(user)
const escapedPassword = shQ(pass)
return `echo ${escapedPassword} | docker login ${escapedRegistry} -u ${escapedUser} --password-stdin`;
}
export const createRegistry = async (
input: typeof apiCreateRegistry._type,
organizationId: string,
@@ -37,7 +49,7 @@ export const createRegistry = async (
message: "Select a server to add the registry",
});
}
const loginCommand = `echo ${input.password} | docker login ${input.registryUrl} --username ${input.username} --password-stdin`;
const loginCommand = safeDockerLoginCommand(input.registryUrl, input.username, input.password)
if (input.serverId && input.serverId !== "none") {
await execAsyncRemote(input.serverId, loginCommand);
} else if (newRegistry.registryType === "cloud") {