mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-28 09:15:18 +02:00
13d0f24423
* Closes #36942 * Fixes #19265 Replaces the SSE-based push channel (`/user/events`) with a WebSocket endpoint (`/-/ws`). ### What changes - **New `/-/ws` endpoint** (authenticated). One WebSocket per origin, shared across tabs via a single `SharedWorker`. - **Pubsub broker** (`services/pubsub`) for fan-out by topic, behind a `Broker` interface. `MemoryBroker` is the default (single process); a Redis backend is available for multi-process setups, configured via `[websocket].PUBSUB_TYPE` / `PUBSUB_CONN_STR`. The internal Gitea queue was not usable here because it has FIFO/single-consumer semantics. - **Push-only event production.** Events are emitted by write-triggered notifiers — `NotificationCountChange`, `PublishStopwatchesForUser`, and the logout publisher — wired into the existing `notify.Notifier` interface. No server-side pollers. - **Typed pub/sub on the client.** `web_src/js/modules/worker.ts` is a singleton transport; features subscribe per event type via `onUserEvent('notification-count', cb)` instead of branching on `event.data.type`. - **Wire contract** (`UserEventType` union) is shared between the worker and consumers via `web_src/js/types.ts`, kept in sync with `services/websocket/events.go`. - **Client-side periodic polling fallback** kicks in only when the WebSocket cannot be established (e.g. proxy blocks WS, browser lacks module-SharedWorker support). ### What's removed - `modules/eventsource` (SSE manager, run loop, messenger). - `/user/events` route and `tests/integration/eventsource_test.go`. - All server-side polling for stopwatches and notification counts. ### Stopwatch multi-tab fix The navbar stopwatch icon was previously rendered conditionally on `{{if $activeStopwatch}}`, so tabs loaded before the timer started had no DOM element to update. The icon and popup are now always rendered (toggled with `tw-hidden`), and the start/stop/cancel handlers POST silently so all open tabs reflect the change in real time. ### Deployment note WebSocket needs the upgrade headers to pass through a reverse proxy, e.g. for nginx: ```nginx proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "upgrade"; ``` Without them the WebSocket cannot be established, and after 3 consecutive failed opens the shared worker signals `push-unavailable`: the notification count and stopwatch fall back to periodic polling on the existing `[ui.notification]` timeouts. Real-time push is lost, the features keep working. The reverse-proxy docs need the same note (see the `docs-update-needed` label). --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Epid <rexmrj@gmail.com>
61 lines
1.7 KiB
Go
61 lines
1.7 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package websocket
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.dev/services/websocket"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestFilterLogout(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
brokerMsg []byte
|
|
connSessID string
|
|
want []byte // expected payload forwarded to the client
|
|
}{
|
|
{
|
|
name: "originating session gets a session-free logout",
|
|
brokerMsg: websocket.MakeUserEventMessage("logout", websocket.LogoutEventData{SessionID: "sess-A"}),
|
|
connSessID: "sess-A",
|
|
want: []byte(`{"eventType":"logout"}`),
|
|
},
|
|
{
|
|
name: "other session is dropped",
|
|
brokerMsg: websocket.MakeUserEventMessage("logout", websocket.LogoutEventData{SessionID: "sess-A"}),
|
|
connSessID: "sess-B",
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "empty sessionID reaches every session",
|
|
brokerMsg: websocket.MakeUserEventMessage("logout", nil),
|
|
connSessID: "sess-A",
|
|
want: []byte(`{"eventType":"logout"}`),
|
|
},
|
|
{
|
|
name: "non-logout message passes through unchanged",
|
|
brokerMsg: websocket.MakeUserEventMessage("other", map[string]any{"k": "v"}),
|
|
connSessID: "sess-A",
|
|
want: []byte(`{"eventType":"other","eventData":{"k":"v"}}`),
|
|
},
|
|
{
|
|
name: "malformed JSON with logout marker passes through unchanged",
|
|
brokerMsg: []byte("any type\nany data"),
|
|
connSessID: "sess-A",
|
|
want: []byte("any data"),
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
eventType, eventData := websocket.ExtractUserEventMessage(tc.brokerMsg)
|
|
out := filterLogout(eventType, eventData, tc.connSessID)
|
|
assert.Equal(t, tc.want, out)
|
|
})
|
|
}
|
|
}
|