mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-15 20:25:18 +02:00
Closes #37670. Today, org members in Gitea only see teams they're a member of. In larger orgs that hurts onboarding and discoverability — there's no way to look up which team owns what without asking around. GitHub solves this with a per-team visibility setting; this PR brings the same model to Gitea. ## What changes - Every team gets a `visibility` setting: - `private` *(default)* — only team members and org owners can see the team. Same as today's behavior. - `limited` — listable by any member of the organization. Members and the repos the team has access to are visible too. Non-org-members still see nothing. - `public` — listable by any signed-in user. - The Owners team visibility is fixed and cannot be changed via settings. - Existing teams default to `private`, so this is a no-op for anyone who doesn't change anything. ## API - `Team`, `CreateTeamOption`, `EditTeamOption` all gain a `visibility` field (string enum: `private` | `limited` | `public`). - `GET /orgs/{org}/teams` and `/orgs/{org}/teams/search` now apply the same visibility rules as the web UI: - site admins and org owners still see every team - other org members see their own teams plus any `limited` or `public` team - `private` teams are no longer leaked through these endpoints - Swagger/OpenAPI specs regenerated. ## UI View from admin2 (not an owner): <img width="1669" height="726" src="https://github.com/user-attachments/assets/daf4bccb-644b-4426-b178-71963aeaf73b" /> View from admin (owner): <img width="2559" height="863" src="https://github.com/user-attachments/assets/4f22cebc-e9df-4fd2-8ed4-724d31fadb7a" /> --------- Signed-off-by: bircni <bircni@icloud.com> Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
105 lines
4.4 KiB
Handlebars
105 lines
4.4 KiB
Handlebars
<div class="ui six wide column">
|
|
<h4 class="ui top attached header flex-left-right">
|
|
<div class="flex-text-inline">
|
|
<strong>{{.Team.Name}}</strong>
|
|
{{if .Team.IsPrivate}}
|
|
<span class="ui mini label" data-tooltip-content="{{ctx.Locale.Tr "org.teams.visibility_private_helper"}}">{{ctx.Locale.Tr "org.teams.visibility_private"}}</span>
|
|
{{else if .Team.IsLimited}}
|
|
<span class="ui mini label" data-tooltip-content="{{ctx.Locale.Tr "org.teams.visibility_limited_helper"}}">{{ctx.Locale.Tr "org.teams.visibility_limited"}}</span>
|
|
{{else if .Team.IsPublic}}
|
|
<span class="ui mini label" data-tooltip-content="{{ctx.Locale.Tr "org.teams.visibility_public_helper"}}">{{ctx.Locale.Tr "org.teams.visibility_public"}}</span>
|
|
{{end}}
|
|
</div>
|
|
<div class="flex-text-block">
|
|
{{if .Team.IsMember ctx $.SignedUser.ID}}
|
|
<button class="ui red mini compact button show-modal" data-modal="#org-member-leave-team"
|
|
data-modal-form.action="{{$.OrgLink}}/teams/{{$.Team.LowerName | PathEscape}}/action/leave?uid={{$.SignedUser.ID}}"
|
|
data-modal-to-leave-team-name="{{$.Team.Name}}"
|
|
>{{ctx.Locale.Tr "org.teams.leave"}}</button>
|
|
{{else if .IsOrganizationOwner}}
|
|
<form method="post" action="{{.OrgLink}}/teams/{{.Team.LowerName | PathEscape}}/action/join">
|
|
<input type="hidden" name="page" value="team">
|
|
<button type="submit" class="ui primary mini compact button" name="uid" value="{{$.SignedUser.ID}}">{{ctx.Locale.Tr "org.teams.join"}}</button>
|
|
</form>
|
|
{{end}}
|
|
</div>
|
|
</h4>
|
|
|
|
<div class="ui attached segment">
|
|
{{if .Team.Description}}
|
|
{{.Team.Description}}
|
|
{{else}}
|
|
<span class="tw-text-text-light tw-italic">{{ctx.Locale.Tr "org.teams.no_desc"}}</span>
|
|
{{end}}
|
|
</div>
|
|
|
|
<div class="ui attached segment">
|
|
{{/* TODO: old indent is kept to make diff changes minimal, can be reformatted in the future */}}
|
|
{{if .Team.IsOwnerTeam}}
|
|
<p>{{ctx.Locale.Tr "org.teams.owners_permission_desc"}}</p>
|
|
<p>{{ctx.Locale.Tr "org.teams.owners_permission_suggestion"}}</p>
|
|
{{else}}
|
|
<h3>{{ctx.Locale.Tr "org.team_access_desc"}}</h3>
|
|
<ul>
|
|
{{if .Team.IncludesAllRepositories}}
|
|
<li>{{ctx.Locale.Tr "org.teams.all_repositories"}}</li>
|
|
{{else}}
|
|
<li>{{ctx.Locale.Tr "org.teams.specific_repositories"}}</li>
|
|
{{end}}
|
|
{{if .Team.CanCreateOrgRepo}}
|
|
<li>{{ctx.Locale.Tr "org.teams.can_create_org_repo"}}</li>
|
|
{{end}}
|
|
</ul>
|
|
{{/* the AccessMode should be either none or admin/owner, the real permissions are provided by each team unit */}}
|
|
{{if false}}{{/*(eq .Team.AccessMode 2)*/}}
|
|
<h3>{{ctx.Locale.Tr "org.settings.permission"}}</h3>
|
|
{{ctx.Locale.Tr "org.teams.write_permission_desc"}}
|
|
{{else if (eq .Team.AccessMode 3)}}
|
|
{{/* FIXME: here might not right, see "FIXME: TEAM-UNIT-PERMISSION", new units might not have correct admin permission*/}}
|
|
<h3>{{ctx.Locale.Tr "org.settings.permission"}}</h3>
|
|
{{ctx.Locale.Tr "org.teams.admin_permission_desc"}}
|
|
{{else}}
|
|
<table class="ui table">
|
|
<thead>
|
|
<tr>
|
|
<th>{{ctx.Locale.Tr "units.unit"}}</th>
|
|
<th>{{ctx.Locale.Tr "org.team_permission_desc"}}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{range $t, $unit := $.Units}}
|
|
{{if (not $unit.Type.UnitGlobalDisabled)}}
|
|
<tr>
|
|
<td><strong>{{ctx.Locale.Tr $unit.NameKey}}</strong></td>
|
|
<td>{{if eq ($.Team.UnitAccessMode ctx $unit.Type) 0 -}}
|
|
{{ctx.Locale.Tr "org.teams.none_access"}}
|
|
{{- else if or (eq $.Team.ID 0) (eq ($.Team.UnitAccessMode ctx $unit.Type) 1) -}}
|
|
{{ctx.Locale.Tr "org.teams.read_access"}}
|
|
{{- else if eq ($.Team.UnitAccessMode ctx $unit.Type) 2 -}}
|
|
{{ctx.Locale.Tr "org.teams.write_access"}}
|
|
{{- end}}</td>
|
|
</tr>
|
|
{{end}}
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
|
|
{{if .IsOrganizationOwner}}
|
|
<div class="ui bottom attached segment">
|
|
<a class="ui small button" href="{{.OrgLink}}/teams/{{.Team.LowerName | PathEscape}}/edit">{{svg "octicon-gear"}} {{ctx.Locale.Tr "org.teams.settings"}}</a>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
<div class="ui mini modal" id="org-member-leave-team">
|
|
<div class="header">
|
|
{{ctx.Locale.Tr "org.teams.leave"}}
|
|
</div>
|
|
<form class="content ui form form-fetch-action" method="post">
|
|
<p>{{ctx.Locale.Tr "org.teams.leave.detail" (HTMLFormat `<span class="%s"></span>` "to-leave-team-name")}}</p>
|
|
{{template "base/modal_actions_confirm" .}}
|
|
</form>
|
|
</div>
|