mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-22 22:35:18 +02:00
f69e15afe7
Addresses a batch of privately reported security issues, grouped by area: - **SSRF** - migration PR-patch/asset fetches, OAuth2 avatar & OpenID discovery, pull-mirror URL re-validation, and the outbound proxy path. - **Access-token scope** - prevent scope escalation on token creation; keep public-only tokens confined (feeds, packages, Actions listings, star/watch lists, limited/private owners). - **Access control / disclosure** - go-get default-branch leak, webhook authorization-header leak, watch clearing on private transitions, label/attachment scoping. - **Denial of service** - input bounds for npm dist-tags, Debian control files, Arch file lists, and SSH keys. ### 📌 Attention for site admins Not breaking - existing configs keep working - but two changes are worth a look: - **New SSRF protection** Outbound requests (migrations, OAuth2 avatars, OpenID discovery, pull mirrors, proxy path) are now validated against the allow/block host lists. If your instance legitimately reaches internal hosts, you may need to add them to `[security].ALLOWED_HOST_LIST` (and the relevant `ALLOW_LOCALNETWORKS` settings). - **Deprecation** `[webhook].ALLOWED_HOST_LIST` is deprecated and will be removed in a future release. Use `[security].ALLOWED_HOST_LIST` instead; the old key still works for now. --------- Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
100 lines
2.9 KiB
Go
100 lines
2.9 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package feed
|
|
|
|
import (
|
|
"time"
|
|
|
|
activities_model "gitea.dev/models/activities"
|
|
"gitea.dev/models/organization"
|
|
"gitea.dev/models/renderhelper"
|
|
"gitea.dev/modules/markup/markdown"
|
|
"gitea.dev/services/context"
|
|
feed_service "gitea.dev/services/feed"
|
|
|
|
"github.com/gorilla/feeds"
|
|
)
|
|
|
|
// ShowUserFeedRSS show user activity as RSS feed
|
|
func ShowUserFeedRSS(ctx *context.Context) {
|
|
showUserFeed(ctx, "rss")
|
|
}
|
|
|
|
// ShowUserFeedAtom show user activity as Atom feed
|
|
func ShowUserFeedAtom(ctx *context.Context) {
|
|
showUserFeed(ctx, "atom")
|
|
}
|
|
|
|
// showUserFeed show user activity as RSS / Atom feed
|
|
func showUserFeed(ctx *context.Context, formatType string) {
|
|
includePrivate := ctx.IsSigned && (ctx.Doer.IsAdmin || ctx.Doer.ID == ctx.ContextUser.ID)
|
|
isOrganisation := ctx.ContextUser.IsOrganization()
|
|
if ctx.IsSigned && isOrganisation && !includePrivate {
|
|
// When feed is requested by a member of the organization,
|
|
// include the private repo's the member has access to.
|
|
isOrgMember, err := organization.IsOrganizationMember(ctx, ctx.ContextUser.ID, ctx.Doer.ID)
|
|
if err != nil {
|
|
ctx.ServerError("IsOrganizationMember", err)
|
|
return
|
|
}
|
|
includePrivate = isOrgMember
|
|
}
|
|
|
|
// a public-only API token must not surface private activity, even for its own owner
|
|
if includePrivate && context.TokenIsPublicOnly(ctx) {
|
|
includePrivate = false
|
|
}
|
|
|
|
actions, _, err := feed_service.GetFeeds(ctx, activities_model.GetFeedsOptions{
|
|
RequestedUser: ctx.ContextUser,
|
|
Actor: ctx.Doer,
|
|
IncludePrivate: includePrivate,
|
|
OnlyPerformedBy: !isOrganisation,
|
|
IncludeDeleted: false,
|
|
Date: ctx.FormString("date"),
|
|
})
|
|
if err != nil {
|
|
ctx.ServerError("GetFeeds", err)
|
|
return
|
|
}
|
|
|
|
rctx := renderhelper.NewRenderContextSimpleDocument(ctx, ctx.ContextUser.HTMLURL(ctx))
|
|
ctxUserDescription, err := markdown.RenderString(rctx,
|
|
ctx.ContextUser.Description)
|
|
if err != nil {
|
|
ctx.ServerError("RenderString", err)
|
|
return
|
|
}
|
|
|
|
feed := &feeds.Feed{
|
|
Title: ctx.Locale.TrString("home.feed_of", ctx.ContextUser.DisplayName()),
|
|
Link: &feeds.Link{Href: ctx.ContextUser.HTMLURL(ctx)},
|
|
Description: string(ctxUserDescription),
|
|
Created: time.Now(),
|
|
}
|
|
|
|
feed.Items, err = feedActionsToFeedItems(ctx, actions)
|
|
if err != nil {
|
|
ctx.ServerError("convert feed", err)
|
|
return
|
|
}
|
|
|
|
writeFeed(ctx, feed, formatType)
|
|
}
|
|
|
|
// writeFeed write a feeds.Feed as atom or rss to ctx.Resp
|
|
func writeFeed(ctx *context.Context, feed *feeds.Feed, formatType string) {
|
|
if formatType == "atom" {
|
|
ctx.Resp.Header().Set("Content-Type", "application/atom+xml;charset=utf-8")
|
|
if err := feed.WriteAtom(ctx.Resp); err != nil {
|
|
ctx.ServerError("Render Atom failed", err)
|
|
}
|
|
} else {
|
|
ctx.Resp.Header().Set("Content-Type", "application/rss+xml;charset=utf-8")
|
|
if err := feed.WriteRss(ctx.Resp); err != nil {
|
|
ctx.ServerError("Render RSS failed", err)
|
|
}
|
|
}
|
|
}
|