mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-19 04:45:18 +02:00
Follow-ups from https://github.com/go-gitea/gitea/pull/37038: - Render the OpenAPI 3.0 spec in the API viewer, it is richer than the Swagger 2.0 rendering - Replace the back link with gitea-styled buttons to view both specs and return to Gitea, flowing above swagger-ui on viewports where they would overlap the title - Key `VisibilityModes` by the string enum type, now named `VisibilityString`, removing the `string()` casts at API call sites - Drop the raw visibility strings from the `Service` settings struct in favor of the typed mode fields, which also removes the org default visibility row from the admin config page - Fix two pre-existing issues surfaced in review: an invalid `DEFAULT_USER_VISIBILITY` was silently accepted as public, and the org visibility error message showed the enum zero value instead of the submitted input Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
154 lines
4.8 KiB
Go
154 lines
4.8 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
api "gitea.dev/modules/structs"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type SearchResults struct {
|
|
OK bool `json:"ok"`
|
|
Data []*api.User `json:"data"`
|
|
}
|
|
|
|
func TestAPIUserSearchLoggedIn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
adminUsername := "user1"
|
|
session := loginUser(t, adminUsername)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
query := "user2"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.NotEmpty(t, results.Data)
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
assert.NotEmpty(t, user.Email)
|
|
}
|
|
|
|
publicToken := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser, auth_model.AccessTokenScopePublicOnly)
|
|
req = NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(publicToken)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
results = DecodeJSON(t, resp, &SearchResults{})
|
|
assert.NotEmpty(t, results.Data)
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
assert.NotEmpty(t, user.Email)
|
|
assert.Equal(t, api.VisibilityStringPublic, user.Visibility)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchNotLoggedIn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
query := "user2"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.NotEmpty(t, results.Data)
|
|
var modelUser *user_model.User
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
modelUser = unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: user.ID})
|
|
assert.Equal(t, modelUser.GetPlaceholderEmail(), user.Email)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchSystemUsers(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
for _, systemUser := range []*user_model.User{
|
|
user_model.NewGhostUser(),
|
|
user_model.NewActionsUser(),
|
|
} {
|
|
t.Run(systemUser.Name, func(t *testing.T) {
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?uid=%d", systemUser.ID)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.NotEmpty(t, results.Data)
|
|
if assert.Len(t, results.Data, 1) {
|
|
user := results.Data[0]
|
|
assert.Equal(t, user.UserName, systemUser.Name)
|
|
assert.Equal(t, user.ID, systemUser.ID)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchAdminLoggedInUserHidden(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
adminUsername := "user1"
|
|
session := loginUser(t, adminUsername)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
query := "user31"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.NotEmpty(t, results.Data)
|
|
for _, user := range results.Data {
|
|
assert.Contains(t, user.UserName, query)
|
|
assert.NotEmpty(t, user.Email)
|
|
assert.Equal(t, api.VisibilityStringPrivate, user.Visibility)
|
|
}
|
|
}
|
|
|
|
func TestAPIUserSearchNotLoggedInUserHidden(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
query := "user31"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.Empty(t, results.Data)
|
|
}
|
|
|
|
func TestAPIUserSearchByEmail(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// admin can search user with private email
|
|
adminUsername := "user1"
|
|
session := loginUser(t, adminUsername)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
query := "user2@example.com"
|
|
req := NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
results := DecodeJSON(t, resp, &SearchResults{})
|
|
assert.Len(t, results.Data, 1)
|
|
assert.Equal(t, query, results.Data[0].Email)
|
|
|
|
// no login user can not search user with private email
|
|
req = NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
results = DecodeJSON(t, resp, &SearchResults{})
|
|
assert.Empty(t, results.Data)
|
|
|
|
// user can search self with private email
|
|
user2 := "user2"
|
|
session = loginUser(t, user2)
|
|
token = getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
req = NewRequestf(t, "GET", "/api/v1/users/search?q=%s", query).
|
|
AddTokenAuth(token)
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
|
|
results = DecodeJSON(t, resp, &SearchResults{})
|
|
assert.Len(t, results.Data, 1)
|
|
assert.Equal(t, query, results.Data[0].Email)
|
|
}
|