mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-18 04:15:18 +02:00
Follow-ups from https://github.com/go-gitea/gitea/pull/37038: - Render the OpenAPI 3.0 spec in the API viewer, it is richer than the Swagger 2.0 rendering - Replace the back link with gitea-styled buttons to view both specs and return to Gitea, flowing above swagger-ui on viewports where they would overlap the title - Key `VisibilityModes` by the string enum type, now named `VisibilityString`, removing the `string()` casts at API call sites - Drop the raw visibility strings from the `Service` settings struct in favor of the typed mode fields, which also removes the org default visibility row from the admin config page - Fix two pre-existing issues surfaced in review: an invalid `DEFAULT_USER_VISIBILITY` was silently accepted as public, and the org visibility error message showed the enum zero value instead of the submitted input Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
161 lines
4.9 KiB
Go
161 lines
4.9 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.dev/modules/glob"
|
|
"gitea.dev/modules/structs"
|
|
"gitea.dev/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLoadServices(t *testing.T) {
|
|
defer test.MockVariableValue(&Service)()
|
|
|
|
cfg, err := NewConfigProviderFromData(`
|
|
[service]
|
|
EMAIL_DOMAIN_WHITELIST = d1, *.w
|
|
EMAIL_DOMAIN_ALLOWLIST = d2, *.a
|
|
EMAIL_DOMAIN_BLOCKLIST = d3, *.b
|
|
`)
|
|
assert.NoError(t, err)
|
|
loadServiceFrom(cfg)
|
|
|
|
match := func(globs []glob.Glob, s string) bool {
|
|
for _, g := range globs {
|
|
if g.Match(s) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
assert.True(t, match(Service.EmailDomainAllowList, "d1"))
|
|
assert.True(t, match(Service.EmailDomainAllowList, "foo.w"))
|
|
assert.True(t, match(Service.EmailDomainAllowList, "d2"))
|
|
assert.True(t, match(Service.EmailDomainAllowList, "foo.a"))
|
|
assert.False(t, match(Service.EmailDomainAllowList, "d3"))
|
|
|
|
assert.True(t, match(Service.EmailDomainBlockList, "d3"))
|
|
assert.True(t, match(Service.EmailDomainBlockList, "foo.b"))
|
|
assert.False(t, match(Service.EmailDomainBlockList, "d1"))
|
|
}
|
|
|
|
func TestLoadServiceVisibilityModes(t *testing.T) {
|
|
defer test.MockVariableValue(&Service)()
|
|
|
|
visibleTypeSlice := func(s ...structs.VisibilityString) (ret []structs.VisibleType) {
|
|
for _, v := range s {
|
|
ret = append(ret, structs.VisibilityModes[v])
|
|
}
|
|
return ret
|
|
}
|
|
testCases := map[string]func(){
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = public
|
|
ALLOWED_USER_VISIBILITY_MODES = public,limited,private
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypePublic, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public", "limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = public
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypePublic, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public", "limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = limited
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypeLimited, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public", "limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
ALLOWED_USER_VISIBILITY_MODES = public,limited,private
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypePublic, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public", "limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = public
|
|
ALLOWED_USER_VISIBILITY_MODES = limited,private
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypeLimited, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = my_type
|
|
ALLOWED_USER_VISIBILITY_MODES = limited,private
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypeLimited, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = my_type
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypePublic, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public", "limited", "private"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
`
|
|
[service]
|
|
DEFAULT_USER_VISIBILITY = public
|
|
ALLOWED_USER_VISIBILITY_MODES = public, limit, privated
|
|
`: func() {
|
|
assert.Equal(t, structs.VisibleTypePublic, Service.DefaultUserVisibilityMode)
|
|
assert.Equal(t, visibleTypeSlice("public"), Service.AllowedUserVisibilityModesSlice.ToVisibleTypeSlice())
|
|
},
|
|
}
|
|
|
|
for tc, fn := range testCases {
|
|
t.Run(tc, func(t *testing.T) {
|
|
Service.AllowedUserVisibilityModesSlice = []bool{true, true, true}
|
|
Service.DefaultUserVisibilityMode = structs.VisibleTypePublic
|
|
cfg, err := NewConfigProviderFromData(tc)
|
|
assert.NoError(t, err)
|
|
loadServiceFrom(cfg)
|
|
fn()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestLoadServiceRequireSignInView(t *testing.T) {
|
|
defer test.MockVariableValue(&Service)()
|
|
|
|
cfg, err := NewConfigProviderFromData(`
|
|
[service]
|
|
`)
|
|
assert.NoError(t, err)
|
|
loadServiceFrom(cfg)
|
|
assert.False(t, Service.RequireSignInViewStrict)
|
|
assert.False(t, Service.BlockAnonymousAccessExpensive)
|
|
|
|
cfg, err = NewConfigProviderFromData(`
|
|
[service]
|
|
REQUIRE_SIGNIN_VIEW = true
|
|
`)
|
|
assert.NoError(t, err)
|
|
loadServiceFrom(cfg)
|
|
assert.True(t, Service.RequireSignInViewStrict)
|
|
assert.False(t, Service.BlockAnonymousAccessExpensive)
|
|
|
|
cfg, err = NewConfigProviderFromData(`
|
|
[service]
|
|
REQUIRE_SIGNIN_VIEW = expensive
|
|
`)
|
|
assert.NoError(t, err)
|
|
loadServiceFrom(cfg)
|
|
assert.False(t, Service.RequireSignInViewStrict)
|
|
assert.True(t, Service.BlockAnonymousAccessExpensive)
|
|
}
|