diff --git a/modules/markup/jupyter/jupyter.go b/modules/markup/jupyter/jupyter.go
index 059046c1365..a02eb4a0287 100644
--- a/modules/markup/jupyter/jupyter.go
+++ b/modules/markup/jupyter/jupyter.go
@@ -6,6 +6,7 @@ package jupyter
import (
"encoding/base64"
"fmt"
+ "html/template"
"io"
"strings"
"sync"
@@ -150,10 +151,8 @@ func (renderer) Render(ctx *markup.RenderContext, input io.Reader, outputWriter
// Check nbformat version
if notebook.Nbformat < 4 {
- htmlWriter.WriteFormat(
- `
This notebook uses an older format (nbformat %d). Only nbformat 4+ is supported for rendering. Please upgrade the notebook in Jupyter or view the raw JSON.
`,
- notebook.Nbformat,
- )
+ msg := htmlutil.HTMLFormat("This notebook uses an older format (nbformat %d). Only nbformat 4+ is supported for rendering. Please upgrade the notebook in Jupyter or view the raw JSON.", notebook.Nbformat)
+ htmlWriter.WriteFormat(`%s
`, msg)
return htmlWriter.Err()
}
@@ -190,9 +189,7 @@ func (renderer) Render(ctx *markup.RenderContext, input io.Reader, outputWriter
}
if truncated {
- htmlWriter.WriteHTML(``)
- htmlWriter.WriteHTML(`Output truncated. This notebook contains too many cells to display efficiently.`)
- htmlWriter.WriteHTML(`
`)
+ renderCellPrompt(htmlWriter, "Warning:", "Output truncated. This notebook contains too many cells to display efficiently.")
}
htmlWriter.WriteHTML(``)
@@ -254,6 +251,16 @@ func renderCellCode(output htmlutil.HTMLWriter, cell Cell, language string) erro
return output.Err()
}
+func renderCellPrompt(output htmlutil.HTMLWriter, left, right template.HTML) {
+ output.WriteFormat(`
+`, left, right)
+}
+
func renderCell(ctx *markup.RenderContext, output htmlutil.HTMLWriter, cell Cell, language string) error {
switch cell.CellType {
case "markdown":
@@ -265,7 +272,10 @@ func renderCell(ctx *markup.RenderContext, output htmlutil.HTMLWriter, cell Cell
if err := renderCellMarkdown(ctx, output, joinSource(cell.Source)); err != nil {
return err
}
- output.WriteHTML(``)
+ output.WriteHTML(`
+
+
+`)
case "code":
output.WriteHTML(``)
if err := renderCellCode(output, cell, language); err != nil {
@@ -273,13 +283,7 @@ func renderCell(ctx *markup.RenderContext, output htmlutil.HTMLWriter, cell Cell
}
output.WriteHTML(`
`)
default:
- output.WriteFormat(`
-
-
-
Cell:
-
[Cell type %s - unsupported, skipped]
-
-
`, cell.CellType)
+ renderCellPrompt(output, "Cell:", htmlutil.HTMLFormat("[Cell type %s - unsupported, skipped]", cell.CellType))
}
return output.Err()
}
diff --git a/modules/markup/jupyter/jupyter_test.go b/modules/markup/jupyter/jupyter_test.go
index fd1464d1727..61d362da987 100644
--- a/modules/markup/jupyter/jupyter_test.go
+++ b/modules/markup/jupyter/jupyter_test.go
@@ -215,7 +215,7 @@ func TestRender(t *testing.T) {
err := r.Render(ctx, strings.NewReader(input), &output)
assert.NoError(t, err)
- assert.Regexp(t, `This notebook uses an older format.*
`, output.String())
+ assert.Regexp(t, `This notebook uses an older format.*
`, output.String())
})
}
diff --git a/templates/repo/blame.tmpl b/templates/repo/blame.tmpl
index d108ea33797..ef3415d52e5 100644
--- a/templates/repo/blame.tmpl
+++ b/templates/repo/blame.tmpl
@@ -28,7 +28,7 @@
-
+
{{if .IsFileTooLarge}}
{{template "shared/filetoolarge" dict "RawFileLink" .RawFileLink}}
diff --git a/templates/repo/settings/lfs_file.tmpl b/templates/repo/settings/lfs_file.tmpl
index b04dc16cdfb..96148f57a9f 100644
--- a/templates/repo/settings/lfs_file.tmpl
+++ b/templates/repo/settings/lfs_file.tmpl
@@ -11,7 +11,7 @@
{{ctx.Locale.Tr "repo.settings.lfs_findcommits"}}
-
+
{{template "repo/unicode_escape_prompt" dict "EscapeStatus" .EscapeStatus "root" $}}
{{if .IsFileTooLarge}}
diff --git a/templates/repo/view_file.tmpl b/templates/repo/view_file.tmpl
index 9f936afb8e0..7d139efceb2 100644
--- a/templates/repo/view_file.tmpl
+++ b/templates/repo/view_file.tmpl
@@ -91,7 +91,7 @@
-
+
{{if not .RenderAsMarkup}}
{{template "repo/unicode_escape_prompt" dict "EscapeStatus" .EscapeStatus}}
{{end}}
diff --git a/web_src/css/repo/file-view.css b/web_src/css/repo/file-view.css
index 3f1c42a4a1f..fec1c7cd8f5 100644
--- a/web_src/css/repo/file-view.css
+++ b/web_src/css/repo/file-view.css
@@ -1,3 +1,9 @@
+.file-view-container {
+ padding: 0 !important; /* the file-view itself provides padding */
+ width: 100% !important; /* override fomantic's "100% + 2px" */
+ max-width: 100% !important;
+}
+
.file-view tr.active .lines-num,
.file-view tr.active .lines-escape,
.file-view tr.active .lines-code {