diff --git a/models/issues/comment.go b/models/issues/comment.go index 40fa999750..0307bb42da 100644 --- a/models/issues/comment.go +++ b/models/issues/comment.go @@ -544,6 +544,9 @@ func (c *Comment) GetSanitizedContentHTML() template.HTML { // LoadLabel if comment.Type is CommentTypeLabel, then load Label func (c *Comment) LoadLabel(ctx context.Context) error { + if c.LabelID == 0 { + return nil + } var label Label has, err := db.GetEngine(ctx).ID(c.LabelID).Get(&label) if err != nil { @@ -551,8 +554,8 @@ func (c *Comment) LoadLabel(ctx context.Context) error { } else if has { c.Label = &label } else { - // Ignore Label is deleted, but not clear this table - log.Warn("Commit %d cannot load label %d", c.ID, c.LabelID) + // label was deleted but comment rows referencing it were not cleaned up + log.Debug("Comment %d references deleted label %d", c.ID, c.LabelID) } return nil diff --git a/models/issues/comment_list.go b/models/issues/comment_list.go index 610bd16f5a..495d48ff44 100644 --- a/models/issues/comment_list.go +++ b/models/issues/comment_list.go @@ -81,7 +81,7 @@ func (comments CommentList) loadLabels(ctx context.Context) error { } for _, comment := range comments { - comment.Label = commentLabels[comment.ID] + comment.Label = commentLabels[comment.LabelID] } return nil }