danielepintore/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-28 09:15:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: git patch apply (#38637)

Browse Source 
Merge duplicate code and add a unit test

There are already integration test cases in `TestEditor` ->
`WebGitCommitEmail` for these two endpoints.
This commit is contained in:
wxiaoguang
2026-07-27 00:57:00 +08:00
committed by GitHub
parent 3e6cb7c16b
commit 470d34b1de
5 changed files with 83 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/git/gitcmd/command.go
View File

@@ -38,11 +38,13 @@ type Command struct {
configArgs []string
// Dir is the working dir for the git command, however:
// FIXME: this could be incorrect in many cases, for example:
// FIXME: GIT-DIR-ARGUMENT: this could be incorrect in many cases, for example:
// * /some/path/.git
// * /some/path/.git/gitea-data/data/repositories/user/repo.git
// If "user/repo.git" is invalid/broken, then running git command in it will use "/some/path/.git", and produce unexpected results
// The correct approach is to use `--git-dir" global argument or "GIT_DIR=..." environment variable.
// Actually, when working with a bare repo, the current directory should not be the git dir,
// otherwise some git commands might overwrite git dir internal files by a repo file.
gitDir string
cmd *exec.Cmd