From c0afc48da8d535a99c8617db33fa7ee516d9d704 Mon Sep 17 00:00:00 2001 From: Mauricio Siu Date: Sun, 19 Jul 2026 21:35:59 -0600 Subject: [PATCH] docs: trim block comment on redactApplicationGitSecrets --- packages/server/src/services/application.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/server/src/services/application.ts b/packages/server/src/services/application.ts index 975f04a0d..38b1c172c 100644 --- a/packages/server/src/services/application.ts +++ b/packages/server/src/services/application.ts @@ -122,14 +122,8 @@ export const findApplicationById = async (applicationId: string) => { return application; }; -/** - * Blanks the git-provider secret columns nested inside an application before it - * is returned to a client. `findApplicationById` eagerly loads the github / - * gitlab / gitea / bitbucket relations (needed server-side to clone), but their - * OAuth tokens, app private key and webhook secret must never reach the browser: - * no client feature reads them, and `application.one` exposed them to any member - * with `service:read` even without git-provider access. - */ +// Blanks the nested git-provider secret columns before an application is sent to +// a client (server-side clone paths use findApplicationById directly). export const redactApplicationGitSecrets = < T extends { github?: Record | null;