From b2484da2aff44aaf192195e496994fcd46537506 Mon Sep 17 00:00:00 2001 From: Mauricio Siu Date: Thu, 5 Feb 2026 15:45:18 -0600 Subject: [PATCH] refactor(backup): replace docker service scale with update command - Updated the backupVolume function to use `docker service update --replicas` instead of `docker service scale` for stopping and starting application replicas. - This change enhances the backup process by ensuring proper handling of service updates with registry authentication. --- packages/server/src/utils/volume-backups/backup.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/server/src/utils/volume-backups/backup.ts b/packages/server/src/utils/volume-backups/backup.ts index cc613ffa9..68f721752 100644 --- a/packages/server/src/utils/volume-backups/backup.ts +++ b/packages/server/src/utils/volume-backups/backup.ts @@ -50,10 +50,10 @@ export const backupVolume = async ( echo "Stopping application to 0 replicas" ACTUAL_REPLICAS=$(docker service inspect ${volumeBackup.application?.appName} --format "{{.Spec.Mode.Replicated.Replicas}}") echo "Actual replicas: $ACTUAL_REPLICAS" - docker service scale ${volumeBackup.application?.appName}=0 + docker service update --replicas=0 ${volumeBackup.application?.appName} ${baseCommand} echo "Starting application to $ACTUAL_REPLICAS replicas" - docker service scale ${volumeBackup.application?.appName}=$ACTUAL_REPLICAS + docker service update --replicas=$ACTUAL_REPLICAS --with-registry-auth ${volumeBackup.application?.appName} `; } if (serviceType === "compose") { @@ -69,10 +69,10 @@ export const backupVolume = async ( echo "Service name: ${compose.appName}_${volumeBackup.serviceName}" ACTUAL_REPLICAS=$(docker service inspect ${compose.appName}_${volumeBackup.serviceName} --format "{{.Spec.Mode.Replicated.Replicas}}") echo "Actual replicas: $ACTUAL_REPLICAS" - docker service scale ${compose.appName}_${volumeBackup.serviceName}=0`; + docker service update --replicas=0 ${compose.appName}_${volumeBackup.serviceName}`; startCommand = ` echo "Starting compose to $ACTUAL_REPLICAS replicas" - docker service scale ${compose.appName}_${volumeBackup.serviceName}=$ACTUAL_REPLICAS`; + docker service update --replicas=$ACTUAL_REPLICAS --with-registry-auth ${compose.appName}_${volumeBackup.serviceName}`; } else { stopCommand = ` echo "Stopping compose container"