From a09cd06eeaa434ef8fe75a028cb9cd261e54195a Mon Sep 17 00:00:00 2001
From: Mauricio Siu <47042324+Siumauricio@users.noreply.github.com>
Date: Fri, 5 Sep 2025 00:56:37 -0600
Subject: [PATCH] refactor: streamline conditional rendering for service
 creation dropdown in EnvironmentPage, improving code readability and
 maintainability

---
 .../environment/[environmentId].tsx           | 73 +++++++++----------
 1 file changed, 36 insertions(+), 37 deletions(-)

diff --git a/apps/dokploy/pages/dashboard/project/[projectId]/environment/[environmentId].tsx b/apps/dokploy/pages/dashboard/project/[projectId]/environment/[environmentId].tsx
index 98e41d221..f87ee8687 100644
--- a/apps/dokploy/pages/dashboard/project/[projectId]/environment/[environmentId].tsx
+++ b/apps/dokploy/pages/dashboard/project/[projectId]/environment/[environmentId].tsx
@@ -786,43 +786,42 @@ const EnvironmentPage = (
 									<ProjectEnvironment projectId={projectId}>
 										<Button variant="outline">Project Environment</Button>
 									</ProjectEnvironment>
-									{auth?.role === "owner" ||
-										(auth?.canCreateServices && (
-											<DropdownMenu>
-												<DropdownMenuTrigger asChild>
-													<Button>
-														<PlusIcon className="h-4 w-4" />
-														Create Service
-													</Button>
-												</DropdownMenuTrigger>
-												<DropdownMenuContent
-													className="w-[200px] space-y-2"
-													align="end"
-												>
-													<DropdownMenuLabel className="text-sm font-normal">
-														Actions
-													</DropdownMenuLabel>
-													<DropdownMenuSeparator />
-													<AddApplication
-														projectName={projectData?.name}
-														environmentId={environmentId}
-													/>
-													<AddDatabase
-														projectName={projectData?.name}
-														environmentId={environmentId}
-													/>
-													<AddCompose
-														projectName={projectData?.name}
-														environmentId={environmentId}
-													/>
-													<AddTemplate environmentId={environmentId} />
-													<AddAiAssistant
-														projectName={projectData?.name}
-														environmentId={environmentId}
-													/>
-												</DropdownMenuContent>
-											</DropdownMenu>
-										))}
+									{(auth?.role === "owner" || auth?.canCreateServices) && (
+										<DropdownMenu>
+											<DropdownMenuTrigger asChild>
+												<Button>
+													<PlusIcon className="h-4 w-4" />
+													Create Service
+												</Button>
+											</DropdownMenuTrigger>
+											<DropdownMenuContent
+												className="w-[200px] space-y-2"
+												align="end"
+											>
+												<DropdownMenuLabel className="text-sm font-normal">
+													Actions
+												</DropdownMenuLabel>
+												<DropdownMenuSeparator />
+												<AddApplication
+													projectName={projectData?.name}
+													environmentId={environmentId}
+												/>
+												<AddDatabase
+													projectName={projectData?.name}
+													environmentId={environmentId}
+												/>
+												<AddCompose
+													projectName={projectData?.name}
+													environmentId={environmentId}
+												/>
+												<AddTemplate environmentId={environmentId} />
+												<AddAiAssistant
+													projectName={projectData?.name}
+													environmentId={environmentId}
+												/>
+											</DropdownMenuContent>
+										</DropdownMenu>
+									)}
 								</div>
 							</div>
 						</div>