diff --git a/Dockerfile b/Dockerfile index 00043b0c2..531cb0820 100644 --- a/Dockerfile +++ b/Dockerfile @@ -56,7 +56,7 @@ RUN curl -sSL https://nixpacks.com/install.sh -o install.sh \ && pnpm install -g tsx # Install Railpack -ARG RAILPACK_VERSION=0.0.64 +ARG RAILPACK_VERSION=0.0.66 RUN curl -sSL https://railpack.com/install.sh | bash # Install buildpacks diff --git a/packages/server/src/utils/builders/railpack.ts b/packages/server/src/utils/builders/railpack.ts index 481dc0faa..cda63e8f9 100644 --- a/packages/server/src/utils/builders/railpack.ts +++ b/packages/server/src/utils/builders/railpack.ts @@ -2,7 +2,10 @@ import { createHash } from "node:crypto"; import type { WriteStream } from "node:fs"; import { nanoid } from "nanoid"; import type { ApplicationNested } from "."; -import { prepareEnvironmentVariables } from "../docker/utils"; +import { + parseEnvironmentKeyValuePair, + prepareEnvironmentVariables, +} from "../docker/utils"; import { getBuildAppDirectory } from "../filesystem/directory"; import { execAsync } from "../process/execAsync"; import { spawnAsync } from "../process/spawnAsync"; @@ -81,10 +84,10 @@ export const buildRailpack = async ( // Add secrets properly formatted const env: { [key: string]: string } = {}; - for (const envVar of envVariables) { - const [key, value] = envVar.split("="); - if (key && value) { - buildArgs.push("--secret", `id=${key},env='${key}'`); + for (const pair of envVariables) { + const [key, value] = parseEnvironmentKeyValuePair(pair); + if (key && value.length > 0) { + buildArgs.push("--secret", `id=${key},env=${key}`); env[key] = value; } } @@ -161,11 +164,11 @@ export const getRailpackCommand = ( // Add secrets properly formatted const exportEnvs = []; - for (const envVar of envVariables) { - const [key, value] = envVar.split("="); - if (key && value) { - buildArgs.push("--secret", `id=${key},env='${key}'`); - exportEnvs.push(`export ${key}=${value}`); + for (const pair of envVariables) { + const [key, value] = parseEnvironmentKeyValuePair(pair); + if (key && value.length > 0) { + buildArgs.push("--secret", `id=${key},env=${key}`); + exportEnvs.push(`export ${key}='${value}'`); } } diff --git a/packages/server/src/utils/docker/utils.ts b/packages/server/src/utils/docker/utils.ts index 840e6f417..61f71381e 100644 --- a/packages/server/src/utils/docker/utils.ts +++ b/packages/server/src/utils/docker/utils.ts @@ -279,6 +279,17 @@ export const prepareEnvironmentVariables = ( return resolvedVars; }; +export const parseEnvironmentKeyValuePair = ( + pair: string, +): [string, string] => { + const [key, ...valueParts] = pair.split("="); + if (!key || !valueParts.length) { + throw new Error(`Invalid environment variable pair: ${pair}`); + } + + return [key, valueParts.join("")]; +}; + export const getEnviromentVariablesObject = ( input: string | null, projectEnv?: string | null, @@ -288,7 +299,7 @@ export const getEnviromentVariablesObject = ( const jsonObject: Record = {}; for (const pair of envs) { - const [key, value] = pair.split("="); + const [key, value] = parseEnvironmentKeyValuePair(pair); if (key && value) { jsonObject[key] = value; }