Dokploy/dokploy
1
0
Fork 0
mirror of https://github.com/Dokploy/dokploy.git synced 2026-06-15 20:25:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3940 from Dokploy/3806-bug-traefik-and-dokploy-fails-to-start-when-port-8080-is-already-in-use-service-crash

Browse Source 
fix: improve port conflict detection by enhancing error messages and …
This commit is contained in:
Mauricio Siu
2026-03-08 03:09:18 -06:00
committed by GitHub
parent ec7df05990 ce82e2322b
commit 8e9ab98a7a
2 changed files with 33 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/dokploy/server/api/routers/settings.ts
View File

@@ -149,12 +149,12 @@ export const settingsRouter = createTRPCRouter({
// Check if port 8080 is already in use before enabling dashboard // Check if port 8080 is already in use before enabling dashboard
const portCheck = await checkPortInUse(8080, input.serverId); const portCheck = await checkPortInUse(8080, input.serverId);
if (portCheck.isInUse) { if (portCheck.isInUse) {
const conflictingContainer = portCheck.conflictingContainer const conflictInfo = portCheck.conflictingContainer
? ` by container "${portCheck.conflictingContainer}"` ? ` by ${portCheck.conflictingContainer}`
: ""; : "";
throw new TRPCError({ throw new TRPCError({
code: "CONFLICT", code: "CONFLICT",
message: `Port 8080 is already in use${conflictingContainer}. Please stop the conflicting service or use a different port for the Traefik dashboard.`, message: `Port 8080 is already in use${conflictInfo}. Please stop the conflicting service or use a different port for the Traefik dashboard.`,
}); });
} }
newPorts.push({ newPorts.push({

39
packages/server/src/services/settings.ts
View File

@@ -413,17 +413,38 @@ export const checkPortInUse = async (
serverId?: string, serverId?: string,
): Promise<{ isInUse: boolean; conflictingContainer?: string }> => { ): Promise<{ isInUse: boolean; conflictingContainer?: string }> => {
try { try {
const command = `docker ps -a --format '{{.Names}}' | grep -v '^dokploy-traefik$' | while read name; do docker port "$name" 2>/dev/null | grep -q ':${port}' && echo "$name" && break; done || true`; // Check if port is in use by a Docker container
const { stdout } = serverId const dockerCommand = `docker ps -a --format '{{.Names}}' | grep -v '^dokploy-traefik$' | while read name; do docker port "$name" 2>/dev/null | grep -q ':${port}' && echo "$name" && break; done || true`;
? await execAsyncRemote(serverId, command) const { stdout: dockerOut } = serverId
: await execAsync(command); ? await execAsyncRemote(serverId, dockerCommand)
: await execAsync(dockerCommand);
const container = stdout.trim(); const container = dockerOut.trim();
return { if (container) {
isInUse: !!container, return {
conflictingContainer: container || undefined, isInUse: true,
}; conflictingContainer: `container "${container}"`,
};
}
// Check if port is in use by a host-level service (non-Docker)
// Dokploy runs inside a container, so we spawn an ephemeral container
// with --net=host to share the host's network stack and use nc -z to
// check if something is listening on the port
const hostCommand = `docker run --rm --net=host busybox sh -c 'nc -z 0.0.0.0 ${port} 2>/dev/null && echo in_use || echo free'`;
const { stdout: hostOut } = serverId
? await execAsyncRemote(serverId, hostCommand)
: await execAsync(hostCommand);
if (hostOut.includes("in_use")) {
return {
isInUse: true,
conflictingContainer: "a host-level service",
};
}
return { isInUse: false };
} catch (error) { } catch (error) {
console.error("Error checking port availability:", error); console.error("Error checking port availability:", error);
return { isInUse: false }; return { isInUse: false };