From 94c00312c1e9bb7c84ace21c4bf343e819489014 Mon Sep 17 00:00:00 2001 From: HarikrishnanD Date: Thu, 30 Oct 2025 12:54:37 +0530 Subject: [PATCH 1/4] feat(volumes): reject spaces/quotes in volume names per Docker rules (#2916) --- .../application/advanced/volumes/add-volumes.tsx | 8 +++++++- .../application/advanced/volumes/update-volume.tsx | 8 +++++++- .../application/volume-backups/handle-volume-backups.tsx | 8 +++++++- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/apps/dokploy/components/dashboard/application/advanced/volumes/add-volumes.tsx b/apps/dokploy/components/dashboard/application/advanced/volumes/add-volumes.tsx index d7621bc1e..2bfd6bbc0 100644 --- a/apps/dokploy/components/dashboard/application/advanced/volumes/add-volumes.tsx +++ b/apps/dokploy/components/dashboard/application/advanced/volumes/add-volumes.tsx @@ -59,7 +59,13 @@ const mySchema = z.discriminatedUnion("type", [ z .object({ type: z.literal("volume"), - volumeName: z.string().min(1, "Volume name required"), + volumeName: z + .string() + .min(1, "Volume name required") + .regex( + /^[a-zA-Z0-9][a-zA-Z0-9_.-]*$/, + "Invalid volume name. Use letters, numbers, '._-' and start with a letter/number.", + ), }) .merge(mountSchema), z diff --git a/apps/dokploy/components/dashboard/application/advanced/volumes/update-volume.tsx b/apps/dokploy/components/dashboard/application/advanced/volumes/update-volume.tsx index 38d02ec90..44fb050bc 100644 --- a/apps/dokploy/components/dashboard/application/advanced/volumes/update-volume.tsx +++ b/apps/dokploy/components/dashboard/application/advanced/volumes/update-volume.tsx @@ -41,7 +41,13 @@ const mySchema = z.discriminatedUnion("type", [ z .object({ type: z.literal("volume"), - volumeName: z.string().min(1, "Volume name required"), + volumeName: z + .string() + .min(1, "Volume name required") + .regex( + /^[a-zA-Z0-9][a-zA-Z0-9_.-]*$/, + "Invalid volume name. Use letters, numbers, '._-' and start with a letter/number.", + ), }) .merge(mountSchema), z diff --git a/apps/dokploy/components/dashboard/application/volume-backups/handle-volume-backups.tsx b/apps/dokploy/components/dashboard/application/volume-backups/handle-volume-backups.tsx index 804b4c39b..e179713de 100644 --- a/apps/dokploy/components/dashboard/application/volume-backups/handle-volume-backups.tsx +++ b/apps/dokploy/components/dashboard/application/volume-backups/handle-volume-backups.tsx @@ -47,7 +47,13 @@ const formSchema = z .object({ name: z.string().min(1, "Name is required"), cronExpression: z.string().min(1, "Cron expression is required"), - volumeName: z.string().min(1, "Volume name is required"), + volumeName: z + .string() + .min(1, "Volume name is required") + .regex( + /^[a-zA-Z0-9][a-zA-Z0-9_.-]*$/, + "Invalid volume name. Use letters, numbers, '._-' and start with a letter/number.", + ), prefix: z.string(), keepLatestCount: z.coerce .number() From 373c78a927e0044ef4d80cc2ed3204b3cad0e9dc Mon Sep 17 00:00:00 2001 From: Amirparsa Baghdadi <76398455+amirparsadd@users.noreply.github.com> Date: Sat, 1 Nov 2025 23:10:58 +0330 Subject: [PATCH 2/4] ArvanCloud new IP Ranges --- packages/server/src/services/cdn.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/server/src/services/cdn.ts b/packages/server/src/services/cdn.ts index 1e19652c1..234405b8e 100644 --- a/packages/server/src/services/cdn.ts +++ b/packages/server/src/services/cdn.ts @@ -616,6 +616,7 @@ const ARVANCLOUD_IP_RANGES = [ "37.32.18.0/27", "37.32.19.0/27", "185.215.232.0/22", + "178.131.120.48/28", ]; const CDN_PROVIDERS: CDNProvider[] = [ From 64e48a7bbec75a576a3c33613bd8eddfa4f50975 Mon Sep 17 00:00:00 2001 From: test Date: Sun, 2 Nov 2025 18:16:08 +0100 Subject: [PATCH 3/4] fix: add JSON responses to compose endpoints that return empty body --- apps/dokploy/server/api/routers/compose.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/dokploy/server/api/routers/compose.ts b/apps/dokploy/server/api/routers/compose.ts index 512ea9718..e2f25b763 100644 --- a/apps/dokploy/server/api/routers/compose.ts +++ b/apps/dokploy/server/api/routers/compose.ts @@ -245,6 +245,7 @@ export const composeRouter = createTRPCRouter({ }); } await cleanQueuesByCompose(input.composeId); + return { success: true, message: "Queues cleaned successfully" }; }), loadServices: protectedProcedure @@ -405,6 +406,7 @@ export const composeRouter = createTRPCRouter({ removeOnFail: true, }, ); + return { success: true, message: "Deployment queued" }; }), redeploy: protectedProcedure .input(apiRedeployCompose) @@ -440,6 +442,7 @@ export const composeRouter = createTRPCRouter({ removeOnFail: true, }, ); + return { success: true, message: "Redeployment queued" }; }), stop: protectedProcedure .input(apiFindCompose) From 65b3ce831f7a585ca7e8608a818ab0905529df07 Mon Sep 17 00:00:00 2001 From: Mauricio Siu <47042324+Siumauricio@users.noreply.github.com> Date: Sun, 2 Nov 2025 17:20:42 -0600 Subject: [PATCH 4/4] feat(domain): truncate project name to comply with domain label length restrictions --- packages/server/src/templates/index.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/server/src/templates/index.ts b/packages/server/src/templates/index.ts index 17c461510..db67cb36f 100644 --- a/packages/server/src/templates/index.ts +++ b/packages/server/src/templates/index.ts @@ -37,7 +37,16 @@ export const generateRandomDomain = ({ const hash = randomBytes(3).toString("hex"); const slugIp = serverIp.replaceAll(".", "-").replaceAll(":", "-"); - return `${projectName}-${hash}${slugIp === "" ? "" : `-${slugIp}`}.traefik.me`; + // Domain labels have a max length of 63 characters + // Reserve space for: hash (6) + separators (1-2) + ip section + dot + traefik.me (10) + // Approx: 6 + 2 + (variable ip length) + 11 = ~19-30 chars for other parts + const maxProjectNameLength = 40; + const truncatedProjectName = + projectName.length > maxProjectNameLength + ? projectName.substring(0, maxProjectNameLength) + : projectName; + + return `${truncatedProjectName}-${hash}${slugIp === "" ? "" : `-${slugIp}`}.traefik.me`; }; export const generateHash = (length = 8): string => {