From 4be25da185672c38f267b48929b74d59d9b08d0e Mon Sep 17 00:00:00 2001 From: Mauricio Siu Date: Sat, 7 Mar 2026 00:41:14 -0600 Subject: [PATCH] fix: add error handling for volume backup notification sending --- .../server/src/utils/volume-backups/utils.ts | 42 +++++++++++-------- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/packages/server/src/utils/volume-backups/utils.ts b/packages/server/src/utils/volume-backups/utils.ts index b508c6b88..20cfbb527 100644 --- a/packages/server/src/utils/volume-backups/utils.ts +++ b/packages/server/src/utils/volume-backups/utils.ts @@ -131,14 +131,18 @@ export const runVolumeBackup = async (volumeBackupId: string) => { ? "mongodb" : volumeBackup.serviceType; - await sendVolumeBackupNotifications({ - projectName, - applicationName: volumeBackup.name, - volumeName: volumeBackup.volumeName, - serviceType: mappedServiceType, - type: "success", - organizationId, - }); + try { + await sendVolumeBackupNotifications({ + projectName, + applicationName: volumeBackup.name, + volumeName: volumeBackup.volumeName, + serviceType: mappedServiceType, + type: "success", + organizationId, + }); + } catch (notificationError) { + console.error("Failed to send volume backup success notification", notificationError); + } } catch (error) { const { VOLUME_BACKUPS_PATH } = paths(!!serverId); const volumeBackupPath = path.join( @@ -160,14 +164,18 @@ export const runVolumeBackup = async (volumeBackupId: string) => { ? "mongodb" : volumeBackup.serviceType; - await sendVolumeBackupNotifications({ - projectName, - applicationName: volumeBackup.name, - volumeName: volumeBackup.volumeName, - serviceType: mappedServiceType, - type: "error", - organizationId, - errorMessage: error instanceof Error ? error.message : String(error), - }); + try { + await sendVolumeBackupNotifications({ + projectName, + applicationName: volumeBackup.name, + volumeName: volumeBackup.volumeName, + serviceType: mappedServiceType, + type: "error", + organizationId, + errorMessage: error instanceof Error ? error.message : String(error), + }); + } catch (notificationError) { + console.error("Failed to send volume backup error notification", notificationError); + } } };