fix: prevent registry password from appearing in error messages and shell commands (#4579)

This commit is contained in:
Mauricio Siu
2026-06-08 09:20:34 -06:00
committed by GitHub
parent e9a0932b23
commit 1f4f94042f
3 changed files with 41 additions and 11 deletions

View File

@@ -1,3 +1,4 @@
import { safeDockerLoginCommand } from "@dokploy/server/services/registry";
import type { ApplicationNested } from "../builders";
export const buildRemoteDocker = async (application: ApplicationNested) => {
@@ -13,7 +14,7 @@ echo "Pulling ${dockerImage}";
if (username && password) {
command += `
if ! echo "${password}" | docker login --username "${username}" --password-stdin "${registryUrl || ""}" 2>&1; then
if ! ${safeDockerLoginCommand(registryUrl || "", username, password)} 2>&1; then
echo "❌ Login failed";
exit 1;
fi