diff --git a/apps/dokploy/__test__/server/mechanizeDockerContainer.test.ts b/apps/dokploy/__test__/server/mechanizeDockerContainer.test.ts index 6eb5d1831..38948ac5c 100644 --- a/apps/dokploy/__test__/server/mechanizeDockerContainer.test.ts +++ b/apps/dokploy/__test__/server/mechanizeDockerContainer.test.ts @@ -4,7 +4,11 @@ import type { ApplicationNested } from "@dokploy/server/utils/builders"; import { mechanizeDockerContainer } from "@dokploy/server/utils/builders"; type MockCreateServiceOptions = { - StopGracePeriod?: number; + TaskTemplate?: { + ContainerSpec?: { + StopGracePeriod?: number; + }; + }; [key: string]: unknown; }; @@ -82,8 +86,10 @@ describe("mechanizeDockerContainer", () => { throw new Error("createServiceMock should have been called once"); } const [settings] = call; - expect(settings.StopGracePeriod).toBe(0); - expect(typeof settings.StopGracePeriod).toBe("number"); + expect(settings.TaskTemplate?.ContainerSpec?.StopGracePeriod).toBe(0); + expect(typeof settings.TaskTemplate?.ContainerSpec?.StopGracePeriod).toBe( + "number", + ); }); it("omits StopGracePeriod when stopGracePeriodSwarm is null", async () => { @@ -97,6 +103,8 @@ describe("mechanizeDockerContainer", () => { throw new Error("createServiceMock should have been called once"); } const [settings] = call; - expect(settings).not.toHaveProperty("StopGracePeriod"); + expect(settings.TaskTemplate?.ContainerSpec).not.toHaveProperty( + "StopGracePeriod", + ); }); }); diff --git a/packages/server/src/utils/builders/index.ts b/packages/server/src/utils/builders/index.ts index bfc3e894a..22789c629 100644 --- a/packages/server/src/utils/builders/index.ts +++ b/packages/server/src/utils/builders/index.ts @@ -125,6 +125,8 @@ export const mechanizeDockerContainer = async ( Image: image, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), ...(command ? { Command: ["/bin/sh"], @@ -153,8 +155,6 @@ export const mechanizeDockerContainer = async ( })), }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try { diff --git a/packages/server/src/utils/databases/mariadb.ts b/packages/server/src/utils/databases/mariadb.ts index d06e808e5..bdfa69a4d 100644 --- a/packages/server/src/utils/databases/mariadb.ts +++ b/packages/server/src/utils/databases/mariadb.ts @@ -73,6 +73,8 @@ export const buildMariadb = async (mariadb: MariadbNested) => { Image: dockerImage, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), ...(command ? { Command: ["/bin/sh"], @@ -106,8 +108,6 @@ export const buildMariadb = async (mariadb: MariadbNested) => { : [], }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try { const service = docker.getService(appName); diff --git a/packages/server/src/utils/databases/mongo.ts b/packages/server/src/utils/databases/mongo.ts index 8fef4f054..7657d3083 100644 --- a/packages/server/src/utils/databases/mongo.ts +++ b/packages/server/src/utils/databases/mongo.ts @@ -121,6 +121,8 @@ ${command ?? "wait $MONGOD_PID"}`; Image: dockerImage, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), ...(replicaSets ? { Command: ["/bin/bash"], @@ -159,8 +161,6 @@ ${command ?? "wait $MONGOD_PID"}`; : [], }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try { diff --git a/packages/server/src/utils/databases/mysql.ts b/packages/server/src/utils/databases/mysql.ts index d1ed8318c..e6183dc9d 100644 --- a/packages/server/src/utils/databases/mysql.ts +++ b/packages/server/src/utils/databases/mysql.ts @@ -79,6 +79,8 @@ export const buildMysql = async (mysql: MysqlNested) => { Image: dockerImage, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), ...(command ? { Command: ["/bin/sh"], @@ -112,8 +114,6 @@ export const buildMysql = async (mysql: MysqlNested) => { : [], }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try { const service = docker.getService(appName); diff --git a/packages/server/src/utils/databases/postgres.ts b/packages/server/src/utils/databases/postgres.ts index 85bc957ae..ffda50592 100644 --- a/packages/server/src/utils/databases/postgres.ts +++ b/packages/server/src/utils/databases/postgres.ts @@ -72,6 +72,8 @@ export const buildPostgres = async (postgres: PostgresNested) => { Image: dockerImage, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), ...(command ? { Command: ["/bin/sh"], @@ -105,8 +107,6 @@ export const buildPostgres = async (postgres: PostgresNested) => { : [], }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try { const service = docker.getService(appName); diff --git a/packages/server/src/utils/databases/redis.ts b/packages/server/src/utils/databases/redis.ts index 35e854058..e0d810660 100644 --- a/packages/server/src/utils/databases/redis.ts +++ b/packages/server/src/utils/databases/redis.ts @@ -70,6 +70,8 @@ export const buildRedis = async (redis: RedisNested) => { Image: dockerImage, Env: envVariables, Mounts: [...volumesMount, ...bindsMount, ...filesMount], + ...(StopGracePeriod !== undefined && + StopGracePeriod !== null && { StopGracePeriod }), Command: ["/bin/sh"], Args: [ "-c", @@ -102,8 +104,6 @@ export const buildRedis = async (redis: RedisNested) => { : [], }, UpdateConfig, - ...(StopGracePeriod !== undefined && - StopGracePeriod !== null && { StopGracePeriod }), }; try {