From 15e90e9ca9c061f7008011383b643112ebdf2c18 Mon Sep 17 00:00:00 2001
From: Mauricio Siu <siumauricio@icloud.com>
Date: Tue, 27 Jan 2026 08:59:58 -0600
Subject: [PATCH] refactor(wss): simplify container ID validation and update
 Docker command structure

---
 apps/dokploy/server/wss/docker-container-terminal.ts | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/apps/dokploy/server/wss/docker-container-terminal.ts b/apps/dokploy/server/wss/docker-container-terminal.ts
index efe2d450e..a2c242d95 100644
--- a/apps/dokploy/server/wss/docker-container-terminal.ts
+++ b/apps/dokploy/server/wss/docker-container-terminal.ts
@@ -3,7 +3,7 @@ import { findServerById, IS_CLOUD, validateRequest } from "@dokploy/server";
 import { spawn } from "node-pty";
 import { Client } from "ssh2";
 import { WebSocketServer } from "ws";
-import { getShell, isValidContainerId, isValidShell } from "./utils";
+import { isValidContainerId, isValidShell } from "./utils";
 
 export const setupDockerContainerTerminalWebSocketServer = (
 	server: http.Server<typeof http.IncomingMessage, typeof http.ServerResponse>,
@@ -34,11 +34,6 @@ export const setupDockerContainerTerminalWebSocketServer = (
 		const serverId = url.searchParams.get("serverId");
 		const { user, session } = await validateRequest(req);
 
-		if (!containerId) {
-			ws.close(4000, "containerId no provided");
-			return;
-		}
-
 		if (!containerId) {
 			ws.close(4000, "containerId not provided");
 			return;
@@ -150,10 +145,9 @@ export const setupDockerContainerTerminalWebSocketServer = (
 					ws.close();
 					return;
 				}
-				const shell = getShell();
 				const ptyProcess = spawn(
-					shell,
-					["-c", `docker exec -it -w / ${containerId} ${activeWay}`],
+					"docker",
+					["exec", "-it", "-w", "/", containerId, shell],
 					{},
 				);