From 0b446d1e2c72f6c26dbd552aaf50bb5d89c88a65 Mon Sep 17 00:00:00 2001 From: Mauricio Siu Date: Sat, 20 Dec 2025 19:52:22 -0600 Subject: [PATCH] refactor(tests): remove redundant cleanup logic from volume backup and restore tests --- .../volume-backups/volume-backup.real.test.ts | 24 ------------------- .../volume-restore.real.test.ts | 24 ------------------- 2 files changed, 48 deletions(-) diff --git a/apps/dokploy/__test__/volume-backups/volume-backup.real.test.ts b/apps/dokploy/__test__/volume-backups/volume-backup.real.test.ts index c21bc61d2..a6a1d49ba 100644 --- a/apps/dokploy/__test__/volume-backups/volume-backup.real.test.ts +++ b/apps/dokploy/__test__/volume-backups/volume-backup.real.test.ts @@ -103,30 +103,6 @@ describe( await cleanupDocker(currentVolumeName); await cleanupFiles(currentAppName); - // Clean all test volumes - try { - const { stdout } = await execAsync( - `docker volume ls -q --filter "name=test-vol-" || true`, - ); - if (stdout.trim()) { - for (const vol of stdout.trim().split("\n")) { - await execAsync(`docker volume rm ${vol} 2>/dev/null || true`); - } - } - } catch { - // Ignore - } - - // Clean all test backup directories - try { - const { VOLUME_BACKUPS_PATH } = paths(false); - await execAsync( - `find "${VOLUME_BACKUPS_PATH}" -maxdepth 1 -type d -name "test-*" -exec rm -rf {} + 2>/dev/null || true`, - ); - } catch { - // Ignore - } - console.log("✅ Cleanup done\n"); }); diff --git a/apps/dokploy/__test__/volume-backups/volume-restore.real.test.ts b/apps/dokploy/__test__/volume-backups/volume-restore.real.test.ts index 2844f4589..2f2095a91 100644 --- a/apps/dokploy/__test__/volume-backups/volume-restore.real.test.ts +++ b/apps/dokploy/__test__/volume-backups/volume-restore.real.test.ts @@ -90,30 +90,6 @@ describe( await cleanupDocker(currentVolumeName); await cleanupFiles(currentAppName); - // Clean all test volumes - try { - const { stdout } = await execAsync( - `docker volume ls -q --filter "name=test-vol-" || true`, - ); - if (stdout.trim()) { - for (const vol of stdout.trim().split("\n")) { - await execAsync(`docker volume rm ${vol} 2>/dev/null || true`); - } - } - } catch { - // Ignore - } - - // Clean all test backup directories - try { - const { VOLUME_BACKUPS_PATH } = paths(false); - await execAsync( - `find "${VOLUME_BACKUPS_PATH}" -maxdepth 1 -type d -name "test-*" -exec rm -rf {} + 2>/dev/null || true`, - ); - } catch { - // Ignore - } - console.log("✅ Cleanup done\n"); });